You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bump spring boot to 3.5.0
bump spring cloud to 2025.0.0
BREAKING CHANGE: it can happen that a misalignment occurs between the version of the junit-platform-launcher provided by gradle and the version of the junit-jupiter-engine provided in the spring dependencies. In this case, gradle is not able to run the tests and throws an error. It's necessary to add testRuntimeOnly 'org.junit.platform:junit-platform-launcher' as a dependency in your build.gradle file then. That takes the version for the unit-platform-launcher from the dependency management.
bump spring boot to 3.5.0
bump spring cloud to 2025.0.0
BREAKING CHANGE: it can happen that a misalignment occurs between the version of the junit-platform-launcher provided by gradle and the version of the junit-jupiter-engine provided in the spring dependencies. In this case, gradle is not able to run the tests and throws an error. It's necessary to add testRuntimeOnly 'org.junit.platform:junit-platform-launcher' as a dependency in your build.gradle file then. That takes the version for the unit-platform-launcher from the dependency management.
removed feign.jaxrs.JakartaContract from sda-commons-starter-web
removed kafkaDltTemplate Bean from sda-commons-starter-kafka
deps: it can happen that a misalignment occurs between the version of the junit-platform-launcher provided by gradle and the version of the junit-jupiter-engine provided in the spring dependencies. In this case, gradle is not able to run the tests and throws an error. It's necessary to add testRuntimeOnly 'org.junit.platform:junit-platform-launcher' as a dependency in your build.gradle file then. That takes the version for the unit-platform-launcher from the dependency management.
Features
remove code that was marked as deprecated and for removal (252bb2f)
Bug Fixes
change code that was marked as deprecated and for removal (adb2b64)
deps: add junit-platform-launcher in the necessary packages (354fc92)
deps: bump spring boot and spring cloud version up (df78ae9)
It's necessary to add testRuntimeOnly 'org.junit.platform:junit-platform-launcher' as a dependency in your build.gradle file then.
Is it possible to ship this dependency in the required version with the module sda-commons-web-testing to make it non-breaking? Or is testRuntimeOnly a scope, we can't provide with a dependency that is used as testImplementation? Would a transitive runtimeOnly become testRuntimeOnly when using our module as testImplementation?
It's necessary to add testRuntimeOnly 'org.junit.platform:junit-platform-launcher' as a dependency in your build.gradle file then.
Is it possible to ship this dependency in the required version with the module sda-commons-web-testing to make it non-breaking? Or is testRuntimeOnly a scope, we can't provide with a dependency that is used as testImplementation? Would a transitive runtimeOnly become testRuntimeOnly when using our module as testImplementation?
based of this comment from spring boot I would say it's not recommend to do this spring-projects/spring-boot#44613 (comment) but if you say it's more important to not have a breaking change I can see what I can do
Also it can be that spring-boot-starter-test is used instead of sda-commons-web-testing, then it still can be an issue
test: it can happen that a misalignment occurs between the version of the junit-platform-launcher found by gradle and the version of the junit-jupiter-engine provided in the spring dependencies. In this case, gradle is not able to run the tests and throws an error. It's necessary to add testRuntimeOnly 'org.junit.platform:junit-platform-launcher' as a dependency in your build.gradle file then. That takes the version for the junit-platform-launcher from the dependency management. Adding this dependency also prepares to support Gradle 9.
deps: updated Spring Boot to 3.5.0, please check the release notes, if any adjustments are necessary.
deps: updated Spring Cloud to 2025.0.0, please check the release notes, if any adjustments are necessary.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bump spring boot to 3.5.0
bump spring cloud to 2025.0.0
BREAKING CHANGE: it can happen that a misalignment occurs between the version of the junit-platform-launcher provided by gradle and the version of the junit-jupiter-engine provided in the spring dependencies. In this case, gradle is not able to run the tests and throws an error. It's necessary to add testRuntimeOnly 'org.junit.platform:junit-platform-launcher' as a dependency in your build.gradle file then. That takes the version for the unit-platform-launcher from the dependency management.